Skip to content

chore: fix JavaScript lint errors (issue #5377)#8591

Closed
suii2210 wants to merge 1 commit intostdlib-js:developfrom
suii2210:fix-lint-precision
Closed

chore: fix JavaScript lint errors (issue #5377)#8591
suii2210 wants to merge 1 commit intostdlib-js:developfrom
suii2210:fix-lint-precision

Conversation

@suii2210
Copy link
Copy Markdown

@suii2210 suii2210 commented Nov 24, 2025

Progresses #5377

Description
This pull request:

Checklist

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Nov 24, 2025
@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Nov 24, 2025
@stdlib-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Nov 24, 2025

Coverage Report

Package Statements Branches Functions Lines
math/base/special/sqrt $\color{green}161/161$
$color{green}+100.00%$
$\color{green}4/4$
$color{green}+100.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}161/161$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@suii2210
Copy link
Copy Markdown
Author

I've updated the PR description to include the contributing guidelines acknowledgement.

@suii2210
Copy link
Copy Markdown
Author

Hi maintainers - I updated the PR description and pushed a GPG-signed commit. Could someone please approve the workflow runs for this fork so CI can execute? Thanks!

@suii2210
Copy link
Copy Markdown
Author

@stdlib-bot maintainers Could someone please approve the workflows and review this PR? Thanks!

@stdlib-bot
Copy link
Copy Markdown
Contributor

⚠️ Tracking Issue Closure Warning ⚠️

I noticed your PR description contains closing keywords ("Resolves", "Closes", or "Fixes") referencing a "Tracking Issue".

Why this matters:
Tracking issues should typically remain open until all related sub-issues are completed. GitHub automatically closes issues with such closing keywords when the PR is merged. For more information, see GitHub's documentation on using keywords in issues and pull requests.

Required action:
Use "Progresses" instead to reference the tracking issue without automatically closing it.

Thank you for your contribution to the project!

@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@suii2210
Copy link
Copy Markdown
Author

Hi @stdlib-bot - I’ve updated the PR description as requested (replaced “Resolves” with “Progresses” and added the contributing-guidelines acknowledgment).

Could you please re-check the PR and allow a maintainer to approve the workflow runs?
Thanks!

@kgryte kgryte added Obsolete Issue or pull request which is no longer relevant. and removed Needs Review A pull request which needs code review. labels Nov 26, 2025
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Nov 26, 2025

Ref: #6433

@suii2210 Thank you for your interest in stdlib; however, the upstream issue was recently closed, as the referenced file was removed in a previous commit, thus rendering the lint issue and its resolution obsolete.

As such, I will go ahead and close this PR. Thank you for your interest in stdlib, and we look forward to your future contributions.

@kgryte kgryte closed this Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Math Issue or pull request specific to math functionality. Obsolete Issue or pull request which is no longer relevant.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants